Difference between revisions of "User:SilentFlame/updatedPipeline"

From Apertium
Jump to navigation Jump to search
Line 18: Line 18:
* personnel repo for the work on this module: https://github.com/SilentFlame/apertium-1/tree/blank-handling
* personnel repo for the work on this module: https://github.com/SilentFlame/apertium-1/tree/blank-handling


All the tests mentioned in '''https://github.com/SilentFlame/apertium-1/tree/blank-handling/tests/transfer''' passes with the updated module.
All the tests mentioned in '''https://github.com/SilentFlame/apertium-1/tree/blank-handling/tests/transfer''' passes with the updated transfer module.


===Interchunk===
===Interchunk===
* <nowiki>Here removing "pos=1" from a "<b>" still outputs the right inline blank: This is because If given a "freeblank" which is between chunks and not a wordbound/inline blank so we need to treat it differently.
let's say for example we have "^SN<sg>{^cheese<n>$}$🍰^SN<sg>{^sale<n>$}$" as an input.
and the rule matches those two chunks and has an action
"
<out>
<chunk pos="1" part="whole"/>
<b/>
<chunk pos="2" part="whole"/>
</out>
"
so if here we treat "<b/>" as just a space then we'll loose "🍰" which won't give much good feel to our users.
So to retain this in the output we handled the freeblanks between chunks.
</nowiki>
* Interchunk was needed to ignore the "pos" argument to '''b''' elements, and output each superblank '''exactly once''', preferably where the rule has a '''b''' element (if there are not enough b's, output the rest at the end of the rule). Here in this module we didn't deal with wordblanks, since we can't look inside chunks when in interchunk.
* Category: Code enhancing
* PR: https://github.com/unhammer/apertium/pull/6
* Tests: https://github.com/SilentFlame/apertium-1/tree/blank-handling-interchunk/tests/interchunk
*
All tests mentioned in '''https://github.com/SilentFlame/apertium-1/blob/blank-handling-interchunk/tests/interchunk/__init__.py''' passes with the updated interchunk module.

Revision as of 10:18, 26 August 2017

For the work done at Progress regarding Automatic_blank_handling

Tasks done

Pretransfer

All the pretransfer tests pass here.

Taransfer(chunker)

All the tests mentioned in https://github.com/SilentFlame/apertium-1/tree/blank-handling/tests/transfer passes with the updated transfer module.

Interchunk

  • Here removing "pos=1" from a "<b>" still outputs the right inline blank: This is because If given a "freeblank" which is between chunks and not a wordbound/inline blank so we need to treat it differently. let's say for example we have "^SN<sg>{^cheese<n>$}$🍰^SN<sg>{^sale<n>$}$" as an input. and the rule matches those two chunks and has an action " <out> <chunk pos="1" part="whole"/> <b/> <chunk pos="2" part="whole"/> </out> " so if here we treat "<b/>" as just a space then we'll loose "🍰" which won't give much good feel to our users. So to retain this in the output we handled the freeblanks between chunks.
  • Interchunk was needed to ignore the "pos" argument to b elements, and output each superblank exactly once, preferably where the rule has a b element (if there are not enough b's, output the rest at the end of the rule). Here in this module we didn't deal with wordblanks, since we can't look inside chunks when in interchunk.
  • Category: Code enhancing
  • PR: https://github.com/unhammer/apertium/pull/6
  • Tests: https://github.com/SilentFlame/apertium-1/tree/blank-handling-interchunk/tests/interchunk

All tests mentioned in https://github.com/SilentFlame/apertium-1/blob/blank-handling-interchunk/tests/interchunk/__init__.py passes with the updated interchunk module.

Retrieved from "https://wiki.apertium.org/w/index.php?title=User:SilentFlame/updatedPipeline&oldid=63991"